↵

GitHub now uses default system font(github.com)

almost 7 years ago from Dominik Schmidt, kreativgebiet.com

  • Weston Thayer, almost 7 years ago

    How the heck do they deal with alignment and vertical rhythm? Every font will have different vertical metrics. Anybody see any bad cases of alignment yet?

    0 points
    • Alec LomasAlec Lomas, almost 7 years ago

      Relative units (rem/em) are your friends, if you learn how to use them properly.

      0 points
      • Weston Thayer, almost 7 years ago

        I don't think they'll help in this case. rem/em don't update with changes to font-family, only font-size.

        0 points
        • Mark Otto, almost 7 years ago

          We're not using relative units in any place save for our Markdown files (to make our rendered Markdown scale easily for mobile, issue comments, and readmes/blobs).

          The few cases of misaligned icons are being fixed as bugs. Overall, we haven't seen too much funkiness across the browsers as the main system fonts are pretty similar size-wise.

          1 point
          • Weston Thayer, almost 7 years ago

            Thanks for the response, that's super interesting. I assumed the vertical metrics would be very different, but didn't bother to check.

            Are the misaligned icon issues font agnostic, or are you having to find a way to make font-specific fixes?

            0 points
            • Mark Otto, almost 7 years ago

              Most are agnostic to any particular font. Haven't run into anything egregious that would require browser-specific overrides yet.

              1 point